Skip to content

feat: implement issue #401 — [Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml - #476

Merged
don-petry merged 4 commits into
mainfrom
dev-lead/issue-401-20260608-0046
Jun 8, 2026
Merged

don-petry merged 4 commits into
mainfrom
dev-lead/issue-401-20260608-0046

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #401

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings June 8, 2026 00:53
@don-petry
don-petry requested a review from a team as a code owner June 8, 2026 00:53
@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d94a3b53-cba2-4a64-b89a-0d3929681c0d

📥 Commits

Reviewing files that changed from the base of the PR and between 8f55465 and 6b23855.

📒 Files selected for processing (2)
  • scripts/aw.sh
  • tests/aw/issue-triage/test_aw_run.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-401-20260608-0046

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new integration test to verify that the safe-output command successfully validates allowed labels and comments. The reviewer recommended mocking the gh CLI tool during this test to prevent external network calls or command-not-found errors, making the test hermetic and avoiding the need to mask failures with || true.

Comment thread tests/aw/issue-triage/test_aw_run.sh Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e57c9f235

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/issue-triage.md Resolved
Comment thread tests/aw/issue-triage/test_aw_run.sh Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — rate-limited (intent: fix-reviews)

PR: #476
The retry cron will re-attempt automatically.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:37
@don-petry
don-petry disabled auto-merge June 8, 2026 05:00
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 8, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #476
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-08T05:38:21Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-08T05:38:21Z

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:08
@don-petry
don-petry disabled auto-merge June 8, 2026 05:25
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:26

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 62935572bb13afc044d8e4c735b5d93bb53ff5ee
Review mode: triage-approved (single reviewer)

Summary

Small, well-scoped bash bug fix in scripts/aw.sh that aligns the frontmatter lookup paths with the actual workflow schema and removes a now-unreachable code path. Adds a hermetic safe-output validation test. Triage tier's low-risk classification is confirmed.

Linked issue analysis

Closes #401 — [Fleet Monitor] issue-triage-runner.yml at 100% failure rate (11/11 runs). The fix targets the most likely root cause: scripts/aw.sh was reading allowed-labels and max-labels from the top level of the workflow frontmatter, but .github/workflows/issue-triage.md actually defines them under safe-outputs.add-labels.allowed and safe-outputs.add-labels.max. This schema mismatch would consistently break the triage runner. The PR updates both python3 extractors to the correct nested path.

Findings

  • Schema fix (correct): scripts/aw.sh now reads fm.get("safe-outputs", {}).get("add-labels", {}).get("allowed", []) and .get("max", 3), matching issue-triage.md exactly.
  • Dead-code removal (safe): The issue_action-based "skip on reopen if any current label is in allowed set" branch is removed along with the local var and fixture lookup. The corresponding workflow only listens for issues: types: [opened], so the reopened branch was unreachable in practice — removal does not change observable behavior.
  • New test (good): tests/aw/issue-triage/test_aw_run.sh adds a hermetic safe-output happy-path test that mocks the gh CLI on PATH (exit 0), directly addressing gemini-code-assist's earlier note about avoiding network calls / || true masking.
  • No security concerns: No changes to auth, secrets, env handling, or shell-injection surface. Existing quoted-heredoc + env-var pattern for user-controlled issue data is preserved.

CI status

All required checks passing: ShellCheck, shellcheck (aw-*.sh), bats, gh-aw-compile, validate-agent-profiles, CodeQL (actions + python), Secret scan (gitleaks), Agent Security Scan, Compile agentic workflows, unit-tests, AgentShield, SonarCloud (Quality Gate passed), Validate AW specs/docs/workflows, dev-lead dispatch, PR Review Agent. CodeRabbit was rate-limited (no findings); Copilot errored (transient); Codex left no suggestions; gemini's suggestion was applied.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry
don-petry disabled auto-merge June 8, 2026 05:38
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 05:38
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@don-petry
don-petry merged commit d14c94c into main Jun 8, 2026
29 checks passed
@don-petry
don-petry deleted the dev-lead/issue-401-20260608-0046 branch June 8, 2026 05:40

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: 6b2385509af78b3f5b721b4538ae70a9c68e1ada
Cascade: triage → deep (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7)

Summary

This PR correctly fixes a schema mismatch: aw.sh was reading allowed-labels and max-labels as flat top-level frontmatter keys that never existed in issue-triage.md, causing 100% failure. The reopen-prevention logic removed was genuinely dead code because the workflow only fires on issues.types=[opened], never reopened. All CI gates pass and the triage signals are fully explained by analysis.

Findings

  • INFO: Schema fix is correct: aw.sh now reads fm.get('safe-outputs',{}).get('add-labels',{}).get('allowed',[]) and .get('max',3), matching the actual nested structure in issue-triage.md. The previous flat keys allowed-labels and max-labels never existed, causing every label to be rejected and a 100% failure rate.
  • INFO: Reopen-prevention logic (skip if has_triage_label && issue_action == reopened) was dead code. The issue-triage.md workflow fires only on issues.types=[opened], so issue_action could never be 'reopened' at runtime. Removal is safe and does not change observable behavior.
  • INFO: New Test 6 in test_aw_run.sh adds a hermetic safe-output happy-path test using a mock gh CLI (exit 0), directly validating that valid labels+comment produce 'validation passed'. Addresses the gemini-code-assist recommendation to avoid network calls and || true masking.
  • INFO: All required checks pass: ShellCheck, bats, CodeQL (actions+python), SonarCloud (Quality Gate passed, 0 new issues, 0 security hotspots), Secret scan (gitleaks), Agent Security Scan, unit-tests, Validate AW specs, AgentShield, validate-agent-profiles, gh-aw-compile. CodeRabbit was rate-limited (no findings); Copilot and Codex left no blocking concerns.
  • INFO: Triage signal 'breaking configuration schema change' is inverted: the change moves aw.sh from reading non-existent flat keys (always empty) to reading the nested schema that actually exists in the workflow file. No existing workflow breaks; the 100% failure is fixed.

Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7). Reply if you need a human review.

don-petry added a commit that referenced this pull request Jun 12, 2026
…rivate — issue-triage-runner.yml (#476)

* feat: implement issue #401 — [Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml

* fix(reviews): address review comments [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 14, 2026
…rivate — issue-triage-runner.yml (#476)

* feat: implement issue #401 — [Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml

* fix(reviews): address review comments [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 18, 2026
…rivate — issue-triage-runner.yml (#476)

* feat: implement issue #401 — [Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml

* fix(reviews): address review comments [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…rivate — issue-triage-runner.yml (#476)

* feat: implement issue #401 — [Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml

* fix(reviews): address review comments [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
…rivate — issue-triage-runner.yml (#476)

* feat: implement issue #401 — [Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml

* fix(reviews): address review comments [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet Monitor] petry-projects/.github-private — issue-triage-runner.yml

3 participants